Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update oauth2_permission_scope documentation #1543

Closed
wants to merge 1 commit into from

Conversation

robertmarsal
Copy link

Fix field marked as optional that is in fact required. When trying to create this resource without the field the following error gets returned:

16:47:34.579 STDERR terraform: │ Error: Could not update application with object ID: "<redacted>"
16:47:34.579 STDERR terraform: │
16:47:34.579 STDERR terraform: │   with module.<redacted>.azuread_application.this,
16:47:34.579 STDERR terraform: │   on ../../../../../../modules/<redacted>/main.tf line 16, in resource "azuread_application" "this":
16:47:34.579 STDERR terraform: │   16: resource "azuread_application" "this" {
16:47:34.579 STDERR terraform: │
16:47:34.579 STDERR terraform: │ unexpected status 400 (400 Bad Request) with error: ValueRequired: Property
16:47:34.579 STDERR terraform: │ value is required but is empty or missing.
16:47:34.580 STDERR terraform: ╵
16:47:34.660 ERROR  terraform invocation failed in .

Once the field is provided the error no longer occurs. The field is also required in the UI as can be seen in the below screenshot

image

Fix field marked as optional that is in fact required
Copy link
Member

@jackofallops jackofallops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HI @robertmarsal - Thanks for this PR. Unfortunately the docs need to reflect the schema code, so the scheme for this property would also need to be updated. However, afaik, value is a conditionally required property, so I don't believe we can mark it as required. If you have links to docs on this, I'm happy to reconsider and help out on getting this change correct?

@robertmarsal
Copy link
Author

Thanks Jack, if it's conditionally required it makes sense. I do not have any links for docs on this to justify it should be always required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants