Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(lex): fix static check warning literalloopclosure #18

Merged
merged 2 commits into from
Sep 2, 2023

Conversation

bluebrown
Copy link
Contributor

fixes loop variable tc captured by func literalloopclosure

@hashicorp-cla
Copy link

hashicorp-cla commented Sep 2, 2023

CLA assistant check
All committers have signed the CLA.

@bluebrown bluebrown changed the title test(lex): fix literalloopclosure test(lex): fix static check warning literalloopclosure Sep 2, 2023
@jimlambrt
Copy link
Collaborator

I took the liberty of pushing a fixup commit that fixes all the other occurrences of this.

Copy link
Collaborator

@jimlambrt jimlambrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty!

@jimlambrt jimlambrt merged commit 98de2aa into hashicorp:main Sep 2, 2023
9 checks passed
@bluebrown
Copy link
Contributor Author

bluebrown commented Sep 2, 2023

ah sorry, for not handling all of them. My toolchain was only marking that one with a warning. I think its because vscode runs the checks only if you save a file or work with it on some way.

@jimlambrt
Copy link
Collaborator

No worries! I appreciate the contribution.

@jimlambrt jimlambrt added the fix label Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants