sourcebundle: remove the option to append anything into a diagnostic that will then panic #64
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the
Append
function from the diagnostics supported by the source bundle package.This function accepts any argument, but will then panic if the user passes in an unsupported type. The only supported types are the
Diagnostic
type and theDiagnostics
type, both of which can be handled normally via the inbuiltappend
function. I think this function exists solely to allow a non-compile time safe way of appending diagnostics which isn't actually a useful thing to have or support.Note, this is a breaking change so when upgrading callers will need to update their usage of these diagnostics to use the
append
function instead of the now-removedAppend
function.