Normalize relative paths to an absolute path #44
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This issue regarding dereferencing symlinks has plagued Terraform v1.3.0+ (reported for several versions here). The first issue, dereferencing symlinks whose targets resolve to symlinks outside of the
src
directory was resolved in #37. The second issue, when thesrc
directory itself is a symlink was resolved in #36. The last issue, and the focus of this PR, deals with normalizing paths when attempting to traverse thesrc
directory. My change is simple: before attempting to traverse thesrc
normalize the path representation to its absolute form.Big thank you to @willhughes-au and @calvinbui for providing the fixture used to test that paths are normalized.
If you'd like to test that this works with Terraform, you will need to
go install .
from main, replacing the indirect dependency for go-slug with a repo containing these changes.