Optimize order of default rules

By moving the .git/ exclusion rule to the end of the default list,
it's possible to skip the entire .git/ directory walk because no
exclusions appear after it. This should slightly speed up packing
performance when the default rules are used or when no additional
exclusion rules are set by .terraformignore.

internal/ignorefiles/terraformignore.go

@@ -171,18 +171,20 @@ func (r *rule) compile() error {
 
 var defaultExclusions = []rule{
 	{
-		val:            strings.Join([]string{"**", ".git", "**"}, string(os.PathSeparator)),
+		val:            strings.Join([]string{"**", ".terraform", "**"}, string(os.PathSeparator)),
 		negated:        false,
 		negationsAfter: true,
 	},
+	// Place negation rules as high as possible in the list
 	{
-		val:            strings.Join([]string{"**", ".terraform", "**"}, string(os.PathSeparator)),
-		negated:        false,
-		negationsAfter: true,
+		val:            strings.Join([]string{"**", ".terraform", "modules", "**"}, string(os.PathSeparator)),
+		negated:        true,
+		negationsAfter: false,
 	},
 	{
-		val:     strings.Join([]string{"**", ".terraform", "modules", "**"}, string(os.PathSeparator)),
-		negated: true,
+		val:            strings.Join([]string{"**", ".git", "**"}, string(os.PathSeparator)),
+		negated:        false,
+		negationsAfter: false,
 	},
 }