broker: Send return error can be context aware.
#115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in the error message
added 4 commits
August 11, 2024 21:55
jimlambrt
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improvement:
When the
Brokerperforms aSendand decides what the returned error should look like, we can include the state of the context (context.Err()) at that moment and allowgetErrorto decide if context information needs to be included in the return.This allows callers to understand why the
Brokermay have ended processing early.Change:
This PR also updates the required version of Go from
1.16to1.20as we now useerrors.Joinadded in1.20. Updates are made to thego.modand CI files and ago mod tidyperformed.It also updates the GHA for checkout and go-version.