Draft: Allow invoked pipelines to complete, mitigate blocking on status channel #113
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DRAFT: IN PROGRESS
This PR is intended to be used initially for discussion of potential changes/improvements to
go-eventlogger
.Perceived issues:
graph.process
TheStatus
channel is changed from unbuffered (default size) to buffered, the size will be the estimated number of nodes within all pipelines (number of root nodes* 3
). This is to prevent occurrence of sending messages to a blocked channel is no longer being received ongraph.process
While ranging over the root nodes, do not invoke roots when we know the context is alreadyDone
graph.doProcess
parameter tweaked so the channel supplied can only be used for sendingbroker.SetRequireAllPipelinesComplete
Added broker-level setting (per event type) to decide whetherprocess
should allow all invoked pipelines to complete and return their status before gathering/fanning-in