feat: add pkiSign function to use vault pki sign api endpoint #1905
+348
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n-marton
force-pushed
the
feat/add-pkisign
branch
from
daa303a
to
fe6b688
Compare
n-marton
force-pushed
the
feat/add-pkisign
branch
2 times, most recently
from
bc92044
to
395376a
Compare
|
hey guys, any chance to have a look on that? |
Signed-off-by: n-marton <[email protected]>
n-marton
force-pushed
the
feat/add-pkisign
branch
from
395376a
to
3dd7245
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull requests intends to add a function to leverage the
signapi endpoint in vault pki.This can be really useful if one plans to use a large number of certificates with low TTL, where the usage of the
issueendpoint can cause high load on the vault servers. By using the sign endpoint one can shift the heaviest part of the problem (the private key generation), from server side to client side.