Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Net 7571 #1880

Merged
merged 3 commits into from
Feb 13, 2024
Merged

Net 7571 #1880

merged 3 commits into from
Feb 13, 2024

Conversation

kkavish
Copy link
Contributor

@kkavish kkavish commented Feb 13, 2024

  • amending string conversion so that map key could also have dc+ns+partition while tracking the dependency.

@kkavish
[NET-7571]
e2f55e4 
- amending string conversion so that map key could also have dc+ns+partition while tracking the dependency.
@kkavish
[NET-7571]
1416f6e 
- updating comments
@kkavish kkavish added the consul-india Consul India team gets notified about the PRs label Feb 13, 2024
@kkavish kkavish requested a review from a team as a code owner February 13, 2024 07:16
@kkavish kkavish mentioned this pull request Feb 13, 2024
Merged
2 tasks
tauhid621
tauhid621 reviewed Feb 13, 2024
View reviewed changes
Copy link
Collaborator

@tauhid621 tauhid621 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a minor comment

dependency/catalog_services.go Outdated Show resolved Hide resolved
dependency/catalog_services.go Show resolved Hide resolved
@kkavish
[NET-7571]
f48de7f 
- updating string
@kkavish kkavish merged commit ac89fff into main Feb 13, 2024
54 checks passed
@kkavish kkavish deleted the NET-7571 branch February 13, 2024 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tauhid621 tauhid621 tauhid621 approved these changes

Assignees
No one assigned
Labels
consul-india Consul India team gets notified about the PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kkavish @tauhid621