Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Consul namespaces/partitions/peering #1822

Merged
merged 2 commits into from
Nov 7, 2023

Conversation

lkysow
Copy link
Member

@lkysow lkysow commented Oct 13, 2023

Add alpha support for specifying namespace, partition, or peer in query param format:

{{ range service "name?partition=foo&ns=bar&peer=baz" }}
- {{ .Name }} {{ .Address }}:{{ .Port }}{{ end }}

Manual testing:

  • namespaces
  • partitions
  • peers

Alpha support because no end to end automated tests yet (will come once build pipeline supports consul enterprise)

Also modify tests to use 1.17.0 since that's the latest release (they failed otherwise)

@lkysow lkysow force-pushed the lkysow/ns-partition-peer-support branch 2 times, most recently from 901cc51 to 40d328b Compare November 3, 2023 18:24
@lkysow lkysow marked this pull request as ready for review November 6, 2023 23:29
@lkysow lkysow requested a review from a team November 6, 2023 23:29
@lkysow lkysow force-pushed the lkysow/ns-partition-peer-support branch from cdfb827 to fe55aa3 Compare November 7, 2023 00:36
Copy link
Contributor

@roncodingenthusiast roncodingenthusiast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@roncodingenthusiast roncodingenthusiast merged commit d0f9f1a into main Nov 7, 2023
54 checks passed
@roncodingenthusiast roncodingenthusiast deleted the lkysow/ns-partition-peer-support branch November 7, 2023 13:46
@blake blake linked an issue Apr 24, 2024 that may be closed by this pull request
@blake blake linked an issue Apr 30, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Cluster Peering with Consul Template Support Cluster Peering in the service / services API functions
2 participants