Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for setting Vault CA from VAULT_CACERT_BYTES env #1782

Merged
merged 3 commits into from
Aug 2, 2023

Conversation

tomhjp
Copy link
Contributor

@tomhjp tomhjp commented Aug 2, 2023

Adds support to set the CA we should trust when communicating with Vault over TLS through a VAULT_CACERT_BYTES environment variable.

The Vault API package supports this since hashicorp/vault#14753

However, without support in consul-template, we end up with weird compatibility. Vault Agent automatically supports consuming that environment variable through the API package for its auto-auth feature, but consul-template reads in TLS configuration differently so Vault Agent's templating doesn't currently work with VAULT_CACERT_BYTES.

See hashicorp/vault-k8s#507 for an example of attempting to use VAULT_CACERT_BYTES in the Agent Injector.

@tomhjp tomhjp requested a review from a team as a code owner August 2, 2023 13:57
@tomhjp tomhjp requested review from roncodingenthusiast and removed request for a team August 2, 2023 13:57
Copy link
Contributor

@VioletHynes VioletHynes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for doing this :)

Copy link
Contributor

@roncodingenthusiast roncodingenthusiast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tomhjp
Copy link
Contributor Author

tomhjp commented Aug 2, 2023

Thanks both!

@tomhjp tomhjp merged commit 347e1cd into main Aug 2, 2023
52 checks passed
@tomhjp tomhjp deleted the add-vault-cacert-bytes-config branch August 2, 2023 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants