[NET-11106] Make bats tesing more reproducible #4345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jm96441n
changed the title
jm96441n
added
pr/no-changelog
jm96441n
commented
Sep 19, 2024
| @@ -24,7 +24,7 @@ jobs: | |||
| with: | |||
| workflow: test.yml | |||
| repo: hashicorp/consul-k8s-workflows | |||
| ref: main | |||
| ref: update-bats-tests | |||
There was a problem hiding this comment.
until the PR against the workflows repo merges this PR will be in draft but is still fine for review
jmurret
force-pushed
the
update-bats-image
branch
from
df69773
to
3150728
Compare
jmurret
requested changes
Sep 19, 2024
| @@ -30,9 +30,10 @@ generate-external-crds: ## Generate CRDs for externally defined CRDs and copy th | |||
| @cd ./control-plane/config/crd/external; \ | |||
| kustomize build | yq --split-exp '.metadata.name + ".yaml"' --no-doc | |||
|
|
|||
|
|
|||
| .PHONY: bats-tests | ||
| bats-tests: ## Run Helm chart bats tests. | ||
| bats --jobs 4 charts/consul/test/unit | ||
| docker run -it -v $(CURDIR):/consul-k8s hashicorpdev/consul-helm-test:latest bats --jobs 4 /consul-k8s/charts/consul/test/unit -f "$(TEST_NAME)" |
There was a problem hiding this comment.
Suggested change
| docker run -it -v $(CURDIR):/consul-k8s hashicorpdev/consul-helm-test:latest bats --jobs 4 /consul-k8s/charts/consul/test/unit -f "$(TEST_NAME)" | |
| docker run -it -v $(CURDIR):/consul-k8s hashicorpdev/consul-helm-test:latest bats --jobs 4 /consul-k8s/charts/consul/test/unit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR
bats-testsmake target so that you can pass in a specific test to run and to use the docker image we use in CI for reproducibility with CI runsHow I've tested this PR
How I expect reviewers to test this PR
Checklist