Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix bats tests #4336

Closed
wants to merge 3 commits into from
Closed

fix bats tests #4336

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8fdffaa
fix bats tests
jm96441n Sep 18, 2024
ca4fb3c
should fail
jm96441n Sep 19, 2024
9811771
maybe fixed?
jm96441n Sep 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
162 changes: 76 additions & 86 deletions charts/consul/test/unit/gateway-resources-job.bats
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,153 +5,143 @@ load _helpers
target=templates/gateway-resources-job.yaml

@test "gatewayresources/Job: fails if .values.apiGateway is set" {
cd `chart_dir`
cd $(chart_dir)
run helm template \
-s templates/tests/test-runner.yaml \
--set 'apiGateway.enabled=true' .
-s templates/tests/test-runner.yaml \
--set 'apiGateway.enabled=true' .
[ "$status" -eq 1 ]
[[ "$output" =~ "[DEPRECATED and REMOVED] the apiGateway stanza is no longer supported as of Consul 1.19.0. Use connectInject.apiGateway instead." ]]
}

@test "gatewayresources/Job: enabled by default" {
cd `chart_dir`
local actual=$(helm template \
-s $target \
. | tee /dev/stderr |
yq 'length > 0' | tee /dev/stderr)
[ "$actual" = "true" ]
cd $(chart_dir)
local actual=$(helm template \
-s $target \
. | tee /dev/stderr |
yq 'length > 0' | tee /dev/stderr)
[ "$actual" = "true" ]
}

@test "gatewayresources/Job: disabled with connectInject.enabled=false" {
cd `chart_dir`
assert_empty helm template \
-s $target \
--set 'connectInject.enabled=false' \
.
cd $(chart_dir)
assert_empty helm template \
-s $target \
--set 'connectInject.enabled=false' \
.
}

@test "gatewayresources/Job: imageK8S set properly" {
cd `chart_dir`
local actual=$(helm template \
-s $target \
--set 'global.imageK8S=foo' \
. | tee /dev/stderr |
yq '.spec.template.spec.containers[0].image == "foo"' | tee /dev/stderr)
[ "$actual" = "true" ]
cd $(chart_dir)
local actual=$(helm template \
-s $target \
--set 'global.imageK8S=foo' \
. | tee /dev/stderr |
yq '.spec.template.spec.containers[0].image == "foo"' | tee /dev/stderr)
[ "$actual" = "true" ]
}

#--------------------------------------------------------------------
# configuration

@test "gatewayresources/Job: default configuration" {
cd `chart_dir`
cd $(chart_dir)
local spec=$(helm template \
-s $target \
. | tee /dev/stderr |
yq '.spec.template.spec.containers[0].args' | tee /dev/stderr)
-s $target \
. | tee /dev/stderr)
# yq '.spec.template.spec.containers[0].args' | tee /dev/stderr)

local actual=$(echo "$spec" | jq 'any(index("-deployment-default-instances=1"))')
local actual=$(echo "$spec" | yq '.spec.template.spec.containers[0].args | contains(["-deployment-default-instances=1"])')
[ "${actual}" = "true" ]

local actual=$(echo "$spec" | jq 'any(index("-deployment-max-instances=1"))')
local actual=$(echo "$spec" | yq '.spec.template.spec.containers[0].args | contains(["-deployment-max-instances=1"])')
[ "${actual}" = "true" ]

local actual=$(echo "$spec" | jq 'any(index("-deployment-min-instances=1"))')
local actual=$(echo "$spec" | yq '.spec.template.spec.containers[0].args | contains(["-deployment-min-instances=1"])')
[ "${actual}" = "true" ]

local actual=$(echo "$spec" | jq 'any(index("-service-type=LoadBalancer"))')
local actual=$(echo "$spec" | yq '.spec.template.spec.containers[0].args | contains(["-service-type=LoadBalancer"])')
[ "${actual}" = "true" ]
}

@test "apiGateway/GatewayClassConfig: custom configuration blah" {
cd `chart_dir`
cd $(chart_dir)
local spec=$(helm template \
-s $target \
--set 'connectInject.apiGateway.managedGatewayClass.deployment.defaultInstances=2' \
--set 'connectInject.apiGateway.managedGatewayClass.deployment.minInstances=1' \
--set 'connectInject.apiGateway.managedGatewayClass.deployment.maxInstances=3' \
--set 'connectInject.apiGateway.managedGatewayClass.nodeSelector=foo: bar' \
--set 'connectInject.apiGateway.managedGatewayClass.copyAnnotations.service.annotations=- bingo' \
--set 'connectInject.apiGateway.managedGatewayClass.serviceType=Foo' \
--set 'connectInject.apiGateway.managedGatewayClass.openshiftSCCName=hello' \
. | tee /dev/stderr |
yq '.spec.template.spec.containers[0].args' | tee /dev/stderr)

local actual=$(echo "$spec" | jq 'any(index("-deployment-default-instances=2"))')
-s $target \
--set 'connectInject.apiGateway.managedGatewayClass.deployment.defaultInstances=2' \
--set 'connectInject.apiGateway.managedGatewayClass.deployment.minInstances=1' \
--set 'connectInject.apiGateway.managedGatewayClass.deployment.maxInstances=3' \
--set 'connectInject.apiGateway.managedGatewayClass.nodeSelector=foo: bar' \
--set 'connectInject.apiGateway.managedGatewayClass.copyAnnotations.service.annotations=- bingo' \
--set 'connectInject.apiGateway.managedGatewayClass.serviceType=Foo' \
--set 'connectInject.apiGateway.managedGatewayClass.openshiftSCCName=hello' \
. | tee /dev/stderr)
# yq '.spec.template.spec.containers[0].args' | tee /dev/stderr)

local actual=$(echo "$spec" | yq '.spec.template.spec.containers[0].args | contains(["-deployment-default-instances=2"])')
[ "${actual}" = "true" ]

local actual=$(echo "$spec" | jq 'any(index("-deployment-max-instances=3"))')
local actual=$(echo "$spec" | yq '.spec.template.spec.containers[0].args | contains(["-deployment-max-instances=3"])')
[ "${actual}" = "true" ]

local actual=$(echo "$spec" | jq 'any(index("-deployment-min-instances=1"))')
local actual=$(echo "$spec" | yq '.spec.template.spec.containers[0].args | contains(["-deployment-min-instances=1"])')
[ "${actual}" = "true" ]

local actual=$(echo "$spec" | jq 'any(index("-service-type=Foo"))')
local actual=$(echo "$spec" | yq '.spec.template.spec.containers[0].args | contains(["-service-type=Foo"])')
[ "${actual}" = "true" ]

local actual=$(echo "$spec" | jq '.[12]')
[ "${actual}" = "\"-node-selector\"" ]

local actual=$(echo "$spec" | jq '.[13]')
[ "${actual}" = "\"foo: bar\"" ]

local actual=$(echo "$spec" | jq '.[14]')
[ "${actual}" = "\"-service-annotations\"" ]
local actual=$(echo "$spec" | yq '.spec.template.spec.containers[0].args | contains(["-node-selector", "foo: bar"])')
[ "${actual}" = "true" ]

local actual=$(echo "$spec" | jq '.[15]')
[ "${actual}" = "\"- bingo\"" ]
local actual=$(echo "$spec" | yq '.spec.template.spec.containers[0].args | contains(["-service-annotations", "- bingo"])')
[ "${actual}" = "true" ]

local actual=$(echo "$spec" | jq '.[16]')
[ "${actual}" = "\"-service-type=Foo\"" ]
local actual=$(echo "$spec" | yq '.spec.template.spec.containers[0].args | contains(["-service-type=Foo"])')
[ "${actual}" = "true" ]
}

@test "apiGateway/GatewayClassConfig: custom configuration openshift enabled" {
cd `chart_dir`
cd $(chart_dir)
local spec=$(helm template \
-s $target \
--set 'global.openshift.enabled=true' \
--set 'connectInject.apiGateway.managedGatewayClass.openshiftSCCName=hello' \
. | tee /dev/stderr |
yq '.spec.template.spec.containers[0].args' | tee /dev/stderr)

local actual=$(echo "$spec" | jq '.[13]')
[ "${actual}" = "\"-openshift-scc-name=hello\"" ]
}
-s $target \
--set 'global.openshift.enabled=true' \
--set 'connectInject.apiGateway.managedGatewayClass.openshiftSCCName=hello' \
. | tee /dev/stderr)
# yq '.spec.template.spec.containers[0].args' | tee /dev/stderr)

local actual=$(echo "$spec" | yq '.spec.template.spec.containers[0].args | contains(["-openshift-scc-name=hello"])')
[ "${actual}" = "true" ]
}

#--------------------------------------------------------------------
# annotations

@test "gatewayresources/Job: no annotations defined by default" {
cd `chart_dir`
cd $(chart_dir)
local actual=$(helm template \
-s $target \
. | tee /dev/stderr |
yq -r '.spec.template.metadata.annotations |
-s $target \
. | tee /dev/stderr |
yq -r '.spec.template.metadata.annotations |
del(."consul.hashicorp.com/connect-inject") |
del(."consul.hashicorp.com/mesh-inject") |
del(."consul.hashicorp.com/config-checksum")' |
tee /dev/stderr)
[ "${actual}" = "{}" ]
tee /dev/stderr)
[ "${actual}" = "{}" ]
}


#--------------------------------------------------------------------
# tolerations

@test "apiGateway/GatewayClassConfig: tolerations" {
cd `chart_dir`
cd $(chart_dir)
local tolerations=$(helm template \
-s templates/gateway-resources-job.yaml \
--set 'connectInject.apiGateway.managedGatewayClass.tolerations=- "operator": "Equal" \
-s templates/gateway-resources-job.yaml \
--set 'connectInject.apiGateway.managedGatewayClass.tolerations=- "operator": "Equal" \
"effect": "NoSchedule" \
"key": "node" \
"value": "clients" \
- "operator": "Equal" \
"effect": "NoSchedule" \
"key": "node2" \
"value": "clients2"' \
. | tee /dev/stderr |
yq '.spec.template.spec.containers[0].args.[13] | contains("operator")' | tee /dev/stderr)
[ "${tolerations}" = "true" ]
}
"value": "clients"' \
. | tee /dev/stderr |
yq '.spec.template.spec.containers[0].args' | tee /dev/stderr)
echo "TOLERATIONS: ${tolerations}"
local actual=$(echo $tolerations | yq 'contains(["tolerations","- \"operator\": \"Equal\" \n\"effect\": \"NoSchedule\" \n\"key\": \"node\" \n\"value\": \"clients\"" ])')
[ "${actual}" = "true" ]
}
Loading