Auth layer umbrella chart #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alfredo Gutierrez <[email protected]>
Signed-off-by: Alfredo Gutierrez <[email protected]>
Signed-off-by: Alfredo Gutierrez <[email protected]>
Signed-off-by: Alfredo Gutierrez <[email protected]>
Signed-off-by: Alfredo Gutierrez <[email protected]>
…for ease of finding a section. Also ordered alphabetically the `values.yaml` file. minor improvements to the documentation suggested by PR review Signed-off-by: Alfredo Gutierrez <[email protected]>
… secretsEnv values, and included it on a secret.yaml template, that can come from global.auth.clientSecret or from secretsEnv.clientSecret, also added a fallback that generates a random secret in case none is provided. Signed-off-by: Alfredo Gutierrez <[email protected]>
…tSecret since this should be provided by the auth server in use. so this changes make it so that when a clientSecret is not provided the chart installation will fail Signed-off-by: Alfredo Gutierrez <[email protected]>
…`auth-server` with the same chart, instructions on how to configure it and GHA WF to test it, modified the previous Chart test name to be more descriptive, since now we have 2 umbrella charts on the repo. Signed-off-by: Alfredo Gutierrez <[email protected]>
AlfredoG87
added
the
New Feature
Signed-off-by: Alfredo Gutierrez <[email protected]>
Signed-off-by: Alfredo Gutierrez <[email protected]>
Signed-off-by: Alfredo Gutierrez <[email protected]>
Signed-off-by: Alfredo Gutierrez <[email protected]>
Signed-off-by: Alfredo Gutierrez <[email protected]>
Signed-off-by: Alfredo Gutierrez <[email protected]>
…le jobs Signed-off-by: Alfredo Gutierrez <[email protected]>
…le jobs Signed-off-by: Alfredo Gutierrez <[email protected]>
Signed-off-by: Alfredo Gutierrez <[email protected]>
Nana-EC
approved these changes
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
auth-proxyand theauth-serverwith the same chartRelated issue(s):
Fixes #22
Notes for reviewer:
Checklist