Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mlcube download log #3

Closed
wants to merge 7 commits into from

Conversation

VukW
Copy link

@VukW VukW commented Feb 19, 2024

While reading output from spawned mlcube process, stop&display not only when a full line (ending with \n) is found, but when a line update (ending with \r) is got.

hasan7n and others added 3 commits February 19, 2024 16:12
* test changing how tokens are stored

* force logout before reauthentication

---------

Co-authored-by: Viacheslav Kukushkin <[email protected]>
Previously we were reading lines separated by \n; now \r also separates a new line to be read
@VukW VukW temporarily deployed to testing-external-code February 19, 2024 18:18 — with GitHub Actions Inactive
@VukW
Copy link
Author

VukW commented Feb 19, 2024

Works well both when docker image is being pulled:
Screenshot 2024-02-19 204734
and when singularity image is being converted:
Screenshot 2024-02-19 205054

VukW and others added 4 commits February 21, 2024 16:45
* Killing all descendant processes on exception

* Fixed tests

* Improved logging
* Checked new updates within git branch

* Bugfix

* Bugfix

* Dummy commit

* Update cli/medperf/utils.py

Co-authored-by: hasan7n <[email protected]>

---------

Co-authored-by: hasan7n <[email protected]>
* better mlcube download logging

* log mlcube output always
# Conflicts:
#	cli/medperf/entities/cube.py
#	cli/medperf/utils.py
@VukW
Copy link
Author

VukW commented Feb 23, 2024

Replaced this PR with one to medperf main branch: mlcommons#545

@VukW VukW closed this Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants