Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow v1.3.x doc link redirect to v1.3 harvester doc #12

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

a110605
Copy link
Collaborator

@a110605 a110605 commented Nov 4, 2024

Summary

Current harvester doc version read from pkg/harvester/package.json

But H. extension needs backward v1.3.x.

This PR updates the mechanism to honor the harvester version from backend settings first.

PR Checklists

  • Do we need to backport this PR change to the Harvester Dashboard?
    • Yes, the relevant PR is at:
  • Are backend engineers aware of UI changes?
    • Yes, the backend owner is:

Related Issue

harvester/harvester#6935

Test screenshot/video

Screenshot 2024-11-04 at 2 15 50 PM Screenshot 2024-11-04 at 2 15 56 PM

Extra technical notes summary

@a110605 a110605 self-assigned this Nov 4, 2024
@a110605 a110605 requested a review from torchiaf November 4, 2024 07:14
@a110605 a110605 changed the title construct doc version from settings harveter version Get harveter doc version from backend settings Nov 4, 2024
Copy link
Collaborator

@torchiaf torchiaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It won't work in case of we are using a dev builds.
Let's merge the compatibility PR first #16 so that here we can adopt the APP_VUE_SERVER_VERSION to work with dev builds.

@a110605 a110605 changed the title Get harveter doc version from backend settings Get harvester doc version from backend settings Nov 8, 2024
@a110605 a110605 changed the title Get harvester doc version from backend settings Allow v1.3.x harvester redirect to v1.3 harvester doc Nov 8, 2024
@a110605 a110605 changed the title Allow v1.3.x harvester redirect to v1.3 harvester doc Allow v1.3.x doc link redirect to v1.3 harvester doc Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants