controller: Do not check volume status if we do not have permission #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bk201
changed the title
- Also, remove the redundant lhclient on node server Signed-off-by: Vicente Cheng <[email protected]>
Vicente-Cheng
force-pushed
the
ad-the-fallback-path
branch
from
e5cbe09
to
047535b
Compare
bk201
changed the title
bk201
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: Please do not create a Pull Request without creating an issue first.
Problem:
The new csi driver did not work if the corresponding clusterrole did not have the correct permission.
Solution:
Skip the volume status checking if the clusterrole did not have corresponding permission.
Related Issue:
harvester/harvester#6849
Test plan: