Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use target_include_directories to publicly expose include dir #8

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

scribam
Copy link

@scribam scribam commented Jul 26, 2024

To use discord-rpc in a project before this change:

add_subdirectory(discord-rpc)
target_include_directories(${PROJECT_NAME} PRIVATE discord-rpc/include)
target_link_libraries(${PROJECT_NAME} PRIVATE discord-rpc)

To use discord-rpc in a project after this change:

add_subdirectory(discord-rpc)
target_link_libraries(${PROJECT_NAME} PRIVATE discord-rpc)

@scribam
Copy link
Author

scribam commented Sep 4, 2024

Hey @p0358 , could you take a look at this when you get a chance? Thanks!

@scribam
Copy link
Author

scribam commented Oct 12, 2024

@p0358 gentle ping

@p0358
Copy link
Member

p0358 commented Oct 14, 2024

Aaa, sorry for the big delay. Yeah this seems to be fine.

@p0358 p0358 merged commit 05eeac6 into harmonytf:master Oct 14, 2024
3 checks passed
@scribam scribam deleted the cmake-include-dir branch October 14, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants