chore: fix url regression

harlan-zw · Mar 3, 2024 · 5521f4d · 5521f4d
1 parent dc2563f
commit 5521f4d
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 6 deletions.
diff --git a/packages/cli/src/ci.ts b/packages/cli/src/ci.ts
@@ -59,8 +59,8 @@ async function run() {
     hasBudget = false
 
   await setCiContext()
-  await start()
-  if (worker.monitor().status === 'completed') {
+  const { routes } = await start()
+  if (!routes.length) {
     logger.error('Failed to queue routes for scanning. Please check the logs with debug enabled.')
     process.exit(1)
   }

diff --git a/packages/cli/src/cli.ts b/packages/cli/src/cli.ts
@@ -30,10 +30,9 @@ async function run() {
 
   const { server, app } = await createServer()
   await unlighthouse.setServerContext({ url: server.url, server: server.server, app })
-  await unlighthouse.start()
-
+  const { routes } = await unlighthouse.start()
   const logger = useLogger()
-  if (unlighthouse.worker.monitor().status === 'completed') {
+  if (!routes.length) {
     logger.error('Failed to queue routes for scanning. Please check the logs with debug enabled.')
     process.exit(1)
   }

diff --git a/packages/core/src/discovery/routes.ts b/packages/core/src/discovery/routes.ts
@@ -23,7 +23,7 @@ export const resolveReportableRoutes: () => Promise<NormalisedRoute[]> = async (
 
   const urls = new Set<string>([])
   // the urls function may be null
-  if (resolvedConfig.urls) {
+  if (resolvedConfig.urls?.length) {
     let urlsToAdd
     if (typeof resolvedConfig.urls === 'function')
       urlsToAdd = [...(await resolvedConfig.urls())]