refactor(ef-core): split the context query and in-memory linq statements

harlam357 · May 22, 2022 · b1cd7a3 · b1cd7a3
1 parent ab21257
commit b1cd7a3
Showing 1 changed file with 7 additions and 3 deletions.
diff --git a/src/HFM.Core/Data/ProteinBenchmarkRepository.cs b/src/HFM.Core/Data/ProteinBenchmarkRepository.cs
@@ -183,8 +183,9 @@ public async Task<ICollection<ProteinBenchmark>> GetBenchmarksAsync(SlotIdentifi
     public async Task<ICollection<ProteinBenchmark>> GetBenchmarksAsync(SlotIdentifier slotIdentifier, IEnumerable<int> projects) =>
         await GetBenchmarksAsync(slotIdentifier, projects, null).ConfigureAwait(false);
 
-    private async Task<ICollection<ProteinBenchmark>> GetBenchmarksAsync(SlotIdentifier slotIdentifier, IEnumerable<int> projects, int? count) =>
-        (await QueryWorkUnitsByClientSlot(slotIdentifier, _context)
+    private async Task<ICollection<ProteinBenchmark>> GetBenchmarksAsync(SlotIdentifier slotIdentifier, IEnumerable<int> projects, int? count)
+    {
+        var query = await QueryWorkUnitsByClientSlot(slotIdentifier, _context)
             .Include(x => x.Protein)
             .Include(x => x.Client)
             .Include(x => x.Platform)
@@ -193,7 +194,9 @@ private async Task<ICollection<ProteinBenchmark>> GetBenchmarksAsync(SlotIdentif
                 .OrderByDescending(y => y.FrameID))
             .Where(x => projects.Contains(x.Protein.ProjectID) && x.Frames.Any())
             .OrderByDescending(x => x.ID)
-            .ToListAsync().ConfigureAwait(false))
+            .ToListAsync().ConfigureAwait(false);
+
+        return query
             .GroupBy(x =>
                 (SlotIdentifier: new SlotIdentifier(
                     ClientIdentifier.FromConnectionString(
@@ -219,6 +222,7 @@ private async Task<ICollection<ProteinBenchmark>> GetBenchmarksAsync(SlotIdentif
             })
             .TakeWhile((_, i) => !count.HasValue || i < count)
             .ToList();
+    }
 
     private static IQueryable<WorkUnitEntity> QueryWorkUnitsByClientSlot(SlotIdentifier slotIdentifier, WorkUnitContext context)
     {