Modified data slicing in BLFReader for when the object type is CAN_ME… #1825
Conversation
…SSAGE, CAN_MESSAGE2 and CAN_ERROR_TXT. This is derived directly from this repository: https://github.com/Technica-Engineering/vector_blf/tree/master.
pyproject.toml
Outdated
| @@ -4,7 +4,8 @@ build-backend = "setuptools.build_meta" | |||
|
|
|||
| [project] | |||
| name = "python-can" | |||
| dynamic = ["readme", "version"] | |||
| dynamic = ["readme"] | |||
| version = "4.3.1" | |||
There was a problem hiding this comment.
Please undo this. The version is set by setuptools-scm from the git tag.
There was a problem hiding this comment.
This is now undone. Please accept if no other problems. Thank you
There was a problem hiding this comment.
@pratik-mahamuni the tests are failing
There was a problem hiding this comment.
@zariiii9003 modified the method equals from the Message class based on the intricacies of how the tests are modeled in the repository. This change could be deemed temporary as the current implementation of the loggers_test.py uses the same data and constructor for all file types (ASC, BLF, CSV etc.).
As equals is used only in tests and not for logic in the code (based on a quick grep), the small change should not have side-effects. I will let you be the judge for that.
…omment from zariii
…hod in the Message class, modified the equal method to make sure that the data being read is equal to the DLC. This is a temporary fix till we agree on what data should be used in the tests, especially pertaining to the BLFReader / BLFWriter constructors
Merge request for #1824.
Please accept if it meets your internal standards.
Thank you