Skip to content

Commit

Permalink
[libc++][docs] Add _LIBCPP_PUSH_MACROS and _LIBCPP_POP_MACROS (ll…
Browse files Browse the repository at this point in the history
…vm#79963)

I got tripped twice after: 7b46225
Let's at least mention these in the `Contributing.rst` doc.
  • Loading branch information
H-G-Hristov authored Jan 30, 2024
1 parent 24a903c commit 21d75ee
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions libcxx/docs/Contributing.rst
Original file line number Diff line number Diff line change
Expand Up @@ -162,6 +162,7 @@ sure you don't forget anything:

- Did you add the relevant feature test macro(s) for your feature? Did you update the ``generate_feature_test_macro_components.py`` script with it?
- Did you run the ``libcxx-generate-files`` target and verify its output?
- If needed, did you add `_LIBCPP_PUSH_MACROS` and `_LIBCPP_POP_MACROS` to the relevant headers?

The review process
==================
Expand Down

0 comments on commit 21d75ee

Please sign in to comment.