Update types #902
Merged
Update types #902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
mempool/claimentry - ClaimEntry .name is not consistent within itself. lib/mining/template BlockClaim.name is not consistent with ClaimEntry. Looking into Proof .data and encoding |
nodech
added
quick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the most basic and least modified types, including those in hd, primitives, coins, covenants, protocol, script, net/packets, utils, and ui.
The goal of this PR is to clean up the types and enable simple reference and "go-to-definition" functionality in the TypeScript Language Server.
Code changes have been kept to an absolute minimum to minimize rebases in other PRs.
The TS JSDoc variation of import syntax is not compatible with standard JSDoc, and this has been handled using the rm-imports plugin from bsdoc.
Note: TSC errors are still present in most places where fixes were applied. However, most of these errors cannot be resolved without more extensive changes, or they result from TypeScript's inability to infer types correctly.