update openwrt Makefile #100
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This disables compiling with -O2 flag since it breaks cross-compiling with at least the MIPS architecture. Optimizations should be safe to re-enable when the build is fixed to handle COPTS compile flags correctly.
|
Awesome, thanks so much for this contribution. If possible, can you explain how I could reproduce the issue? (like, do you own a MIPS device or something?). It would be nice of course to keep optimizations even if it means more work to fix the build. |
Yes, I'm build this for a MIPS device when I encounter this issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This disables compiling with -O2 flag since it breaks cross-compiling with at least the MIPS architecture.
Optimizations should be safe to re-enable when the build is fixed to handle COPTS compile flags correctly.