Send notification for new device #6555
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awu0403
force-pushed
the
send-notification-for-new-device
branch
from
7c7658e
to
8153729
Compare
awu0403
force-pushed
the
send-notification-for-new-device
branch
2 times, most recently
from
37093bb
to
aba4e22
Compare
added 2 commits
August 16, 2024 09:48
awu0403
force-pushed
the
send-notification-for-new-device
branch
from
b0c453f
to
faf2cae
Compare
r350178982
reviewed
Aug 16, 2024
| request.session.flush() | ||
| if request.user.username not in already_logged_list: | ||
| already_logged_list.append(request.user.username) | ||
| request.session['_already_logged'] = already_logged_list | ||
| if hasattr(request, 'user'): | ||
| from seahub.base.accounts import User |
There was a problem hiding this comment.
把 if request.user.username 写到if里面来
r350178982
reviewed
Aug 16, 2024
seahub/auth/views.py
Outdated
| @@ -73,6 +77,21 @@ def log_user_in(request, user, redirect_to): | |||
|
|
|||
| # Okay, security checks complete. Log the user in. | |||
| auth_login(request, user) | |||
| enable_login_email = bool(UserOptions.objects.get_login_email_enable_status(user.username)) | |||
| already_logs = request.session.get('_already_logged', []) | |||
There was a problem hiding this comment.
already_logs --> already_login_users
r350178982
reviewed
Aug 16, 2024
seahub/auth/__init__.py
Outdated
| @@ -106,7 +106,11 @@ def logout(request): | |||
| session data. | |||
| Also remove all passwords used to decrypt repos. | |||
| """ | |||
| already_logged_list = request.session.get('_already_logged', []) | |||
There was a problem hiding this comment.
_already_logged-->_already_loging_users, 定义一个全局变量来保存这个session的key
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.