[Docs, Batch] Document need for copying keys in developer namespaces #14664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisvittal
approved these changes
Aug 22, 2024
patrick-schultz
approved these changes
Aug 28, 2024
cjllanwarne
added a commit
to cjllanwarne/hail
that referenced
this pull request
Oct 24, 2024
… rotate_keys.py (hail-is#14735) ## Change Description Corrects our gsa-key copying instructions (from hail-is#14664) to copy the key contents, not the entire secret metadata. The batch service seems resilient to these badly formed secrets, but the rotate_keys.py script was not. ## Security Assessment Delete all except the correct answer: - This change has a low security impact ### Impact Description - Not a production change - Does not add any new information to the secrets, only formats them a useable way. - Only in dev namespaces (Reviewers: please confirm the security impact before approving)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the discussions here.
It seems that this is not the most desirable eventual state, but for now, it seems better to document this than ignore it.