Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[query] Update testng and scalatest versions for IDEA support #14277

Merged

Conversation

ehigham
Copy link
Member

@ehigham ehigham commented Feb 9, 2024

Later versions of IDEA can't run tests with our current testng and scalatest versions. Update to latest and fix fallout.

@ehigham ehigham force-pushed the ehigham/update-testng-for-intellij branch from 0dc3fc1 to 1b5c86f Compare February 9, 2024 03:07
@ehigham
Copy link
Member Author

ehigham commented Feb 9, 2024

Needs #14158

@ehigham ehigham marked this pull request as ready for review February 9, 2024 03:34
@ehigham ehigham force-pushed the ehigham/update-testng-for-intellij branch from 03c1fa4 to 9b05a47 Compare April 11, 2024 17:26
@patrick-schultz
Copy link
Collaborator

Looks good to me. This need to wait for #14158 to merge, right?

Copy link
Collaborator

@patrick-schultz patrick-schultz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just needs a rebase!

Later versions of IDEA can't run tests with our current testng and
scalatest versions. Update to latest and fix fallout.
@ehigham ehigham force-pushed the ehigham/update-testng-for-intellij branch from 9b05a47 to e508f85 Compare April 12, 2024 18:39
Copy link
Collaborator

@patrick-schultz patrick-schultz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, sorry, thought it was still stacked on #14158

@hail-ci-robot hail-ci-robot merged commit dbe0f56 into hail-is:main Apr 12, 2024
2 checks passed
@ehigham ehigham deleted the ehigham/update-testng-for-intellij branch April 12, 2024 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants