Generic recipes: rework #161
Open
+344
−39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
extrowerk
changed the title
fbrosson
reviewed
May 20, 2018
fbrosson
reviewed
May 20, 2018
alaviss
reviewed
May 28, 2018
|
Can someone wrap this one up? It'd be nice to have these in place in time for GCI |
|
Is there anything else what we want to include in the examples? |
diversys
reviewed
Aug 14, 2019
Begasus
reviewed
Nov 28, 2020
scottmc
requested changes
Oct 18, 2021
Begasus
force-pushed
the
generic_recipe_samples
branch
2 times, most recently
from
5530daf
to
54efb38
Compare
jmairboeck
reviewed
Oct 23, 2024
Begasus
force-pushed
the
generic_recipe_samples
branch
4 times, most recently
from
25e1cc7
to
0d8aa86
Compare
Begasus
reviewed
Oct 23, 2024
Begasus
force-pushed
the
generic_recipe_samples
branch
2 times, most recently
from
cbc7894
to
5bcf8e8
Compare
Begasus
force-pushed
the
generic_recipe_samples
branch
2 times, most recently
from
6e654bb
to
098c6f1
Compare
|
OK, pushed some changes to the generic ones, could use some extra eyes again. @waddlesplash @scottmc @korli @extrowerk @diversys @jmairboeck @OscarL |
Begasus
force-pushed
the
generic_recipe_samples
branch
from
098c6f1
to
bce90eb
Compare
jmairboeck
reviewed
Oct 23, 2024
|
|
||
| TEST() | ||
| { | ||
| make check |
There was a problem hiding this comment.
I don't think that makefile-engine has a check target, or does it? If not, I would just remove the TEST function from this.
| haiku_devel | ||
| " | ||
|
|
||
| # add python versions if needed: eg (3.10 3.11) |
There was a problem hiding this comment.
Suggested change
| # add python versions if needed: eg (3.10 3.11) | |
| # add python versions if needed: eg (3.10 3.13) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.