Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/PartialEq::ne #2

Merged
merged 3 commits into from
Mar 18, 2024
Merged

Conversation

elpiel
Copy link
Contributor

@elpiel elpiel commented Mar 17, 2024

Fixes #1


mod impls;
pub use impls::*;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not actually needed and was complaining that imports are not used.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i would like to leave this in, as this is needed to be compatible with the core / std implementation. (see README)
(Or am I wrong?)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what you mean by compatible.
Can you elaborate?

image

rust-toolchain.toml Outdated Show resolved Hide resolved
@haennes
Copy link
Owner

haennes commented Mar 17, 2024

Hey,

first of all.
Thanks for engaging in this project.
This has been laying around for a couple of months somewhat awaiting the approval of iliekturles.
I am however motivated to keep working on this. (to get started you may first take a look at the code generator)
Documentation is really bad sadly. Maybe i will have time to write some tomorrow

Signed-off-by: Lachezar Lechev <[email protected]>
@elpiel
Copy link
Contributor Author

elpiel commented Mar 17, 2024

No worries I'm always happy to help with something I am quite interested in.

I tried building the units but the build script never ends. Left it for a few minutes but nothing happened.

I will be giving a talk at Rust Nation and I would like to include the const generics version of UOM.
Hopefully, we can get more contributors but also make some awareness in regards to the nightly features that we still need stabilized.

@elpiel
Copy link
Contributor Author

elpiel commented Mar 17, 2024

Ps: Need one more fix for one impl, I'll open a PR.

@haennes
Copy link
Owner

haennes commented Mar 17, 2024

No worries I'm always happy to help with something I am quite interested in.

I tried building the units but the build script never ends. Left it for a few minutes but nothing happened.

I will be giving a talk at Rust Nation and I would like to include the const generics version of UOM. Hopefully, we can get more contributors but also make some awareness in regards to the nightly features that we still need stabilized.

Great :)
It would be great if we get a compiling version until then.....
Could you specify which talk in paticular. Couldnt find it 🤦
I am a huge fan of these nightly features in paticular, as they are a game changer for many applications... Hopefully they will get stable soon :)
On that note: Do you know of any efforts to support generic const generics? (see here)

@elpiel
Copy link
Contributor Author

elpiel commented Mar 18, 2024

It would be great if we get a compiling version until then.....
Yes, I really want to get this up and running but lately with my schedule I'd try to do the best I can to prepare the crate for the talk, otherwise I can always mention it.

Could you specify which talk in paticular. Couldnt find it 🤦
The talk title is "Typed for safety"

On that note: Do you know of any efforts to support generic const generics? (see iliekturtles/uom#381 (comment))

No idea to be honest...

@haennes
Copy link
Owner

haennes commented Mar 18, 2024

great.

any opinions on the discussion above about the

use impls

@elpiel
Copy link
Contributor Author

elpiel commented Mar 18, 2024

great.

any opinions on the discussion above about the

use impls

It should not be needed. An implemented trait on a type is just that, there's nothing to export.
Let's leave it as it is for now. It can always be removed.

@haennes haennes merged commit 0067b25 into haennes:main Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cannot call non-const fn <Self as PartialEq<Rhs>>::eq in constant functions
2 participants