-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/PartialEq::ne
#2
Conversation
Signed-off-by: Lachezar Lechev <[email protected]>
Signed-off-by: Lachezar Lechev <[email protected]>
|
||
mod impls; | ||
pub use impls::*; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not actually needed and was complaining that imports are not used.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i would like to leave this in, as this is needed to be compatible with the core / std implementation. (see README)
(Or am I wrong?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, first of all. |
Signed-off-by: Lachezar Lechev <[email protected]>
No worries I'm always happy to help with something I am quite interested in. I tried building the units but the build script never ends. Left it for a few minutes but nothing happened. I will be giving a talk at Rust Nation and I would like to include the const generics version of UOM. |
Ps: Need one more fix for one impl, I'll open a PR. |
Great :) |
No idea to be honest... |
great. any opinions on the discussion above about the use impls |
It should not be needed. An implemented trait on a type is just that, there's nothing to export. |
Fixes #1