ci: benchmarking and Cachix improvements #1230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to some changes and greater efficiencies in our CI system, we can now rely again on Nix's built-in benchmarking support; that is, use the `requiredSystemFeatures = ["benchmark"]` Nix property on benchmarking derivations to guarantee that benchmarks will only run on benchmark-capable hosts. For posterity, the more flexible Buildkite queue-based benchmark system *did* work, but it's no longer necessary, and doing things the Nix way has a few advantages; namely that the configuration is simpler, and that Nix will run benchmark jobs as soon as they're ready. The Buildkite approach we used waited for all the other builds to finish before kicking off the benchmarks, even if the benchmark's dependencies had already been built. Signed-off-by: Drew Hess <[email protected]>
We no longer need this, as our CI system now writes directly to our public Cachix cache in real time. Signed-off-by: Drew Hess <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.