ci: only run Wasm tests once a PR reaches the merge queue #1226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Wasm tests are very expensive, and our build system isn't smart enough to know when they don't need to be re-run, so for now, we only run the tests once a PR hits the merge queue. Signed-off-by: Drew Hess <[email protected]>
|
Note that this implementation will still build the Primer Wasm test suite in all cases; it just won't run them except under the conditions explained in the commit message. I think this will be good enough. |
|
Hmm, adding the label didn't cause Buildkite to run the tests — it took the I'll need to look into this, but this isn't sufficient to block the merge. First and foremost, we need not to run the Wasm tests on every PR/push. I'll leave #1222 open so that I remember to come back and investigate this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Wasm tests are very expensive, and our build system isn't smart enough to know when they don't need to be re-run, so for now, we only run the tests once a PR hits the merge queue.