Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify order "desc" and orderBy "dateModified" #1933

Closed
wants to merge 1 commit into from

Conversation

roslynwythe
Copy link
Member

@roslynwythe roslynwythe commented Nov 3, 2024

Fixes #1930

What changes did you make?

  • Specify order "desc" and orderBy "dateModified" in call to getComparator

Why did you make the changes (we will use this info to test)?

  • Previously "order" and "orderBy" were not set according to requirements

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied

image

Visuals after changes are applied

image

Copy link
Member

@entrotech entrotech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR would force the sort order to always be by modified date descending. The issue asked to set the default sort order - i.e., the sort order when the page is first loaded. The user should still be able to change the sort order from the various column popup windows.

@ExperimentsInHonesty ExperimentsInHonesty marked this pull request as draft November 7, 2024 03:39
@entrotech
Copy link
Member

entrotech commented Nov 13, 2024

I clearly did not explain what default sort order meant well enough in the issue.
-Implemented the default sort order on PR#1951
Changes to this PR are no longer needed.

@entrotech entrotech closed this Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set the default project sort order on the My Projects Page to Last Modified Date, descending
2 participants