Fastapi conversion #818
Merged
Fastapi conversion #818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates alembic migrations, creates docker compose environment, and creates test users for local development.
The create_groups_users.py program needed to get the db URL from the environment variable.
The example has keys and values that can be used directly during development.
In this commit, the frontend will still fail to build due to test errors. However, that is being fixed in parallel and this will ensure that the frontend will be able to run in a container when it does get fixed.
This commit includes basic documentation about pre-populated test user accounts.
By having the backend depend on pgadmin, the `db` container will transitively be run too.
Updated the service URLs.
The backend startup scripts that pre-populated moto server was allowing duplicate data to be added to moto. This happens when moto server is running while the API is repeatedly started using the `entrypoint` script.
tylerthome
approved these changes
Oct 9, 2024
Comment on lines
+75
to
+84
| sql = 'INSERT INTO public.user (email, "firstName", "lastName", "roleId") VALUES (%s, %s, %s, %s) ON CONFLICT(email) DO NOTHING' | ||
| url = urlparse(os.environ['DATABASE_URL']) | ||
| with psycopg2.connect(database=url.path[1:], | ||
| user=url.username, | ||
| password=url.password, | ||
| host=url.hostname, | ||
| port=url.port) as db_conn: | ||
| with db_conn.cursor() as cur: | ||
| cur.executemany(sql, rows) | ||
| db_conn.commit() |
There was a problem hiding this comment.
Is the direct use of postgres bindings here for simplicity (in place of sqlalchemy) or is there a more important reason to be aware of? I'm good with this, just curious to see if we can make a note about it
There was a problem hiding this comment.
Yeah, for simplicity only. I hope someone at some time will build on this. This suffers from the issue of synchronizing the model from the app and this statement.
The backend entrypoint script has a check for "prod" as in production. In a production environment, there would not be a need to create test users. So, this commit moves towards the idea of having a production environment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #789
What changes did you make?
motoserver as a containerpgAdmin4as a containerRationale behind the changes?
Testing done for these changes