Remove typescript errors #817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The authentication test has been updated with the new API paths and expected sign-in request body. These changes are now synced with the API's expectations.
paulespinosa
requested changes
Oct 18, 2024
The port used during development and testing changed back to 4040.
…la/HomeUniteUs into remove_typescript_errors
…la/HomeUniteUs into remove_typescript_errors
paulespinosa
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #789
What changes did you make?
I fixed multiple imports and testing problems that were causing the CI workflow to fail during TypeScript compilation and the Vite build phase. The port was updated in the vite.config file and the github action run tests file. I also fixed tests to ensure the correct api paths and component testing for loading and error states in forgot password code tests and reset password tests.
Rationale behind the changes?
The Github CI flow is failing because of TypeScript errors, missing imports, and failing tests. These are needed for the build phase in github actions as well as building the docker files for the incubator.
Testing done for these changes
Tests were run in the frontend directory using Vitetest and Cypress. All the tests are passing.