Update validation schemas

[mira-kine]

Closes #595

What changes did you make?

• Updated regex in SignInForm with special characters regex in PasswordValidationSchema

Testing done for these changes

• Tried signing up with special characters not explicit in SignIn but passes in SignUp, then tried signing back in. SignIn button was disabled until I used the same regex code for both.

[paulespinosa]

@mira-kine Good start! Why isn't utils password validation schema being used here? And please add tests. Let us know if you would like any help.

Here's some ideas for test cases:

test123!
Testing!
Test123!
Test1234
12345678
7væVPj¼±mó5÷ÙÞW
Xin chào 1 bạn!

[mira-kine]

@paulespinosa the utils validation schemas is not shared across the components because we are validating differently here. In SignUp, we are using Formik + Yup to check that a user inputs a valid password before it is entered into the db, but for SignIn, we are only validating that there is a password at all. We had made this change after I made my PR, so I forgot to update it. Good catch - the PR should be updated with these changes now. I also updated the PR with the regex changes. Will be pushing up tests on SignUpForm special characters next.

[paulespinosa]

@mira-kine Got it, makes sense. Thank you! The changes look good so far.

[Joshua-Douglas]

Hey @mira-kine,

Thanks for the changes. The code changes look great, but the test cases are failing and I have some comments on the docs.

I made some suggestions that should help fix the test cases but I have a few more observations:

1. Running the test cases gives this warning:

Warning: An update to PasswordValidation inside a test was not wrapped in act(...).

When testing, code that causes React state updates should be wrapped into act(...):

act(() => {
  /* fire events that update state */
});
/* assert on the output */

I was able to dismiss it by wrapping the render and fireEvent calls in the act block. I'm not sure if there is a more elegant solution.

2. SignInForm.should display error text test case is failing because the login form no longer contains the password must contain message. We removed that message in this PR, so you can remove that check.
3. I couldn't get the 7væVPj¼±mó5÷ÙÞW test case to pass, even though this validation passes in the browser. I suspect there is an issue with the testing code, but I couldn't find it. Maybe @erikguntner might see the issue if you can't sort it out.