Remove lastName required parameter from the OpenAPI user schema

hackforla · Apr 1, 2024 · 4a1ac90 · 4a1ac90
1 parent 74f861e
commit 4a1ac90
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 7 deletions.
diff --git a/api/openapi_server/controllers/auth_controller.py b/api/openapi_server/controllers/auth_controller.py
@@ -72,7 +72,7 @@ def sign_up(body: dict, role: UserRole):
                 role=role,
                 firstName=body['firstName'],
                 middleName=body.get('middleName', ''),
-                lastName=body['lastName']
+                lastName=body.get('lastName', '')
             )
     except Exception as error:
         raise AuthError({"message": str(error)}, 400)

diff --git a/api/openapi_server/openapi/schemas/_index.yaml b/api/openapi_server/openapi/schemas/_index.yaml
@@ -73,7 +73,6 @@ UserSchema:
   required:
     - email
     - firstName 
-    - lastName
 UserSignupSchema:
   type: object
   allOf:

diff --git a/api/tests/test_authentication.py b/api/tests/test_authentication.py
@@ -47,11 +47,6 @@ def test_signup_with_missing_fields(client, endpoint):
             'email': '[email protected]',
             'password': 'Fakepass%^&7!asdf'
         },
-        {
-            'email': '[email protected]',
-            'password': 'Fakepass%^&7!asdf',
-            'firstName': 'Josh'
-        },
         {
             'email': '[email protected]',
             'password': 'Fakepass%^&7!asdf',