New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A ton of small fixes #1286

Closed

ofluffydev wants to merge 1 commit into hackclub:main from ofluffydev:main

ofluffydev commented Jul 24, 2024

In the "NotFoundPage" dark was being set by simply putting the attribute in the element (Nav component just checks if it exists or not I think so it may not affect the actual website, hopefully my fix is correct)
Numerous duplicate attributes were present throughout the code. I either commented out/removed the unnecessary ones.
In footer.js there is css inside of js that was written incorrectly causing errors. Fixed this by destructuring the props.
I updated "var" throughout the repo to let/const depending on which was the correct one to use.
I added lang="en" to tags that were missing it.
On the bin landing page there was an incorrect use of id attributes that I converted to classes.
Throughout the mdx files, there were uses of https: that were incorrect that I replaced with Nextjs links. There were also old links to http (not secure) that I converted to https.
I removed some unnecessary imports. Combined some CSS attributes into shorthand versions.


          A ton of small fixes

cd10ff8

vercel bot commented Jul 24, 2024

@ofluffydev is attempting to deploy a commit to the Hack Club Team on Vercel.

A member of the Team first needs to authorize it.

vercel bot commented Aug 10, 2024 •

edited

Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
site	✅ Ready (Inspect)	Visit Preview	💬 7 unresolved	Aug 10, 2024 1:38am

vercel bot deployed to Preview

August 10, 2024 01:38

View deployment

Member

lachlanjc commented Aug 10, 2024

📝 Changed routes:

/404	/amas/geohot
^{(view full size)}	^{(view full size)}

/amas/sal	/amas/vitalik
^{(view full size)}	^{(view full size)}

…/[userAirtableID]/shop	/arcade
^{(view full size)}	^{(view full size)}

And 13 other routes:

Commit cd10ff8 (https://site-q5384tv18.hackclub.dev).

Member

bellesea commented Aug 11, 2024

@ofluffydev thank youu!!!!

a few small things, eventhough there's a () in the main page the footer is now darkmode...

ofluffydev closed this by deleting the head repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet