Set/get broadcast address in TunInterface #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conradev
force-pushed
the
broadcast-addresses
branch
from
2ff39d6
to
a81a903
Compare
|
@sampoder the tests are failing |
perhaps the interface needs to be brought up in the test after setting |
|
Sorry about not checking up those tests, checking now! For MacOS & Windows, they're failing because this is currently only implemented on Linux. For Linux, well that's a whole separate question... |
sampoder
commented
Aug 17, 2023
|
Fixed that error, but we've got a new one now: @conradev any idea what addresses are available for broadcast addresses? I was under the impression it worked the same as IPV4. |
sampoder
commented
Aug 17, 2023
Modelled after TunInterface's IPV4 logic. Uses SIOCGIFBRDADDR & SIOCSIFBRDADDR. View https://man7.org/linux/man-pages/man7/netdevice.7.html.
conradev
force-pushed
the
broadcast-addresses
branch
from
8f474bb
to
43782cc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modelled after TunInterface's IPV4 logic; uses SIOCGIFBRDADDR & SIOCSIFBRDADDR. View https://man7.org/linux/man-pages/man7/netdevice.7.html.