initial burrow gtk #135
Closed
initial burrow gtk #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conradev
approved these changes
Jul 1, 2023
reesericci
force-pushed
the
burrow-gtk-patch-1
branch
2 times, most recently
from
26cfc6b
to
cdd39af
Compare
|
Build succeeded & all comments resolved. Ready for review |
|
Closes #83 |
conradev
reviewed
Jul 5, 2023
Also run these tests on Github Actions as part of the PR request flow.
conradev
force-pushed
the
burrow-gtk-patch-1
branch
from
972dd77
to
eecbeae
Compare
Muirrum
requested changes
Oct 5, 2023
Comment on lines
+1
to
+4
| pub static VERSION: &str = "0.1.0"; | ||
| pub static GETTEXT_PACKAGE: &str = "burrow-gtk"; | ||
| pub static LOCALEDIR: &str = "/app/share/locale"; | ||
| pub static PKGDATADIR: &str = "/app/share/burrow-gtk"; |
There was a problem hiding this comment.
curious where these magic values come from?
|
I'm not really working on this anymore - someone can feel free to fork & send in a new PR if they want to work on it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.