-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move tests into the tests
directory & run tests on GH Actions
#123
Conversation
c5e0467
to
470490d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to fix two things here:
-
The test command should match the build command more. We should test all targets and features. We should also make explicit which targets we are testing in the matrix configuratio (i.e. the host target)
-
The test command seemingly recompiles the crate, I'd be curious why it can't re-use the previous compile (might be for the above reason)
Let me look into recompilation, that'll speed things up a lot when removed! |
.github/workflows/build-rust.yml
Outdated
@@ -60,3 +60,6 @@ jobs: | |||
- name: Build | |||
shell: bash | |||
run: cargo build --verbose --workspace --all-features --target ${{ join(matrix.targets, ' --target ') }} | |||
- name: Post-Build Tests | |||
shell: bash | |||
run: cargo test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
run: cargo test | |
run: cargo test --verbose --workspace --all-features --target ${{ join(matrix.targets, ' --target ') }} |
@conradev is this what you're looking for?
Based on sagiegurari/cargo-make#251, it seems like removing |
Also run these tests on Github Actions as part of the PR request flow.
290284e
to
d6d490c
Compare
The successor to #121... rebasing is doing my head in but full steam ahead! This PR works towards resolving #82 & #60.