-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[170] feat: Dropdown Menu Styling for Donor and Recipient Cards #187
Open
lemezze
wants to merge
39
commits into
develop
Choose a base branch
from
170-dropdown-menu-styling-mui
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…schemas [129]refactor: modify schemas
…e into sprint-refactor
* connecting page to backend * update * update * connecting to backend for view-logs * attempting to add toggle functionality in datagrid * functionality for toggling between dropoffs and pickups * fix: added dirname to eslint file in frontend * publish branch * added buttons * feat- dropdowns created * refactor - removed foodtype references * chore: linting --------- Co-authored-by: Ishaan Sathaye <[email protected]> Co-authored-by: esauerbo <[email protected]>
* feat: finished changing text entry to dropdowns * chore: linting --------- Co-authored-by: esauerbo <[email protected]>
* feat: added attribue tabs for admin page * feat:added attribute tabs for admin page * fix: linting * fix: linting for AdminDataScreen.tsx --------- Co-authored-by: oprylord <[email protected]> Co-authored-by: Ishaan Sathaye <[email protected]>
* refactor: dropofflogschema * refactor - pickup dropoff * refactor - remove foodtype * refactor - recipient * refactor - vehicles schema * refactor - file name * chore: linting --------- Co-authored-by: esauerbo <[email protected]>
…schemas (#158) * refactor: fixed eslint errors * refactor: fixed eslint errors * refactor: fixed eslint errors * refactor: fixed eslint errors * refactor: fixed all eslint errors
* feat - create fieldroutes.js * feat - protectAdmin * feat - field routes * feat: changing the post in add field to put * chore: removing name from params --------- Co-authored-by: esauerbo <[email protected]>
* Created skeleton for driverSummary * feat: driver summary frontend * Delete frontend/src/components/driverSummary directory * feat: Driver Summary frontend changes * feat: adjusted spacing between discrepancies * [132] feat: adjust alignment + add back button * [132] feat: adjust alignment + add back button * feat: changed text area * linting errors for tsx and stashing conflict on CSS file --------- Co-authored-by: Ishaan Sathaye <[email protected]>
* feat - make field controllers * refactor - async handler * refactor - getFields, createField * refactor - editField * refactor - errors * refactor - getFieldByName * refactor - small fix * refactor - small fix * refactor - editField, deleteField * createField * refactor - updateField * refactor - fieldControllers * refactor - fieldControllers * refactor - fieldControllers, done * feat: linting and erorr handling * chore: updating comments * fix: updating paths in logs controller * feat: formatting * chore: restoring logs controller * feat: removing admin from try block and adding status to error codes --------- Co-authored-by: esauerbo <[email protected]>
* feat:added attribute tabs for admin page * test * feat:added attribute tabs for admin page * draft * draft * chore: removed adding newLocation * 152: remove drivers new locations * fix: locationform no longer bugged --------- Co-authored-by: oprylord <[email protected]> Co-authored-by: Ishaan Sathaye <[email protected]>
…ie-rescue into sprint-refactor
* created a field page file * feat: can press buttons for field names * feat: can press buttons for fields * feat: added field page for entity type * feat: populated field names for donors & recipient * feat: created fieldform component * feat: adding update/new forms for fields * added titles + create/update/delete for all fields * fix: vehicle to fieldName, remove console msgs * fix: field names no longer empty * combining recip and donor food types * fix: removing two food types * remove duplication for donors and recip food types * chore: linting --------- Co-authored-by: esauerbo <[email protected]>
* refactor: weight greater than 0 check * feat: error handling for pickups * feat: weight error checking * fix: update dropoff with filtered list --------- Co-authored-by: esauerbo <[email protected]>
* feat - first commit * feat - start fieldService.tsx * feat - fieldService.tsx * chore: linting * refactor - fieldService * refactor - fieldService inteface --------- Co-authored-by: esauerbo <[email protected]>
* feat - created fieldSlice.tsx * feat - getFields, pending, fulfilled, rejected * feat - createField, updateField * feat - .addCase for createfield, updatefield * getFieldByName * feat: deleteField --------- Co-authored-by: esauerbo <[email protected]>
* added changes to driver auth tsx * chore: linting --------- Co-authored-by: esauerbo <[email protected]>
* refactor - driver model array of dates * refactor - punch out route * refacor - log in controller * feat - clockout * refactor - loginDriver * feat - punchOutDriver * refactor - punchOutDriver * chore: linting --------- Co-authored-by: esauerbo <[email protected]>
* refactor: updated driver summary page ui * refactor: small fix * quick fix --------- Co-authored-by: esauerbo <[email protected]> Co-authored-by: Ishaan Sathaye <[email protected]>
lemezze
added
enhancement
New feature or request
frontend
admin
Issues for the Admin side of the project
labels
Jun 25, 2023
lemezze
changed the title
[#170] feat: Dropdown Menu Styling for Donor and Recipient Cards
[170] feat: Dropdown Menu Styling for Donor and Recipient Cards
Jun 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Developer: Leticia Mezzetti
Pull Request Summary
Developers worked on changing text boxes to a drop-down format for the Donor and Recipient Forms on the Admin Side. I changed the TSX/CSS files to style the dropdown menu and spacing between text.
I had to change the MUI Menu items by applying sharper curved edges around the menu box, changing the highlighting color when selecting the dropdown to a green color (#F0F9F1), and making all selection boxes have the same length.
Here is what the new Donor form looks like:
Here is what the new Recipient form looks like:
Pull Request Checklist
(Acutally check off the boxes to make sure you've done everything)
[issue #] type: description
AFTER REVIEW
Reviewer Checklist - PULL REQUEST REVIEWER ONLY
IMPORTANT: The rest of the sections in this checklist should only be filled out by authorized pull request reviewers. If you are the individual contributor, do not fill out the rest of the fields or check the boxes.
Reviewer: Full Name
NOTE: Pull requests should only be merged when all boxes are checked.