Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iss58 #69

Open
wants to merge 9 commits into
base: dev
Choose a base branch
from
Open

Iss58 #69

wants to merge 9 commits into from

Conversation

tung-aiden
Copy link
Collaborator

Sign In authentication

@gitguardian
Copy link

gitguardian bot commented Feb 12, 2023

⚠️ GitGuardian has uncovered 9 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id Secret Commit Filename
5678879 Generic High Entropy Secret fefdd4e frontend/amplify/#current-cloud-backend/amplify-meta.json View secret
5678879 Generic High Entropy Secret fefdd4e frontend/amplify/backend/amplify-meta.json View secret
5678879 Generic High Entropy Secret 609947c frontend/amplify/#current-cloud-backend/amplify-meta.json View secret
5678879 Generic High Entropy Secret 609947c frontend/amplify/backend/amplify-meta.json View secret
5678879 Generic High Entropy Secret 609947c frontend/src/aws-exports.js View secret
5678879 Generic High Entropy Secret 1d98f88 frontend/src/aws-exports.js View secret
5678879 Generic High Entropy Secret 1d98f88 frontend/src/aws-exports.js View secret
5678879 Generic High Entropy Secret f926bd5 frontend/src/aws-exports.js View secret
5678879 Generic High Entropy Secret f926bd5 frontend/src/aws-exports.js View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@VincentPheng
Copy link
Collaborator

VincentPheng commented Feb 12, 2023

Missing: Login persistence

See: https://docs.amplify.aws/lib/auth/manageusers/q/platform/js/#retrieve-current-authenticated-user

Quick summary:
When a user first logs in, Amplify adds a bunch of things to the session storage and local storage. The method mentioned in the link will get those items and tell you whether or not a user is logged in. When a user is on the landing page, check if there is already a user logged in. If there is, navigate them to '/home/dashboard'. If there is no user logged in, do nothing.

@VincentPheng
Copy link
Collaborator

Please fix conflicts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants