Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed export bugs on contact and discussion pages #158

Merged
merged 2 commits into from
Aug 3, 2023
Merged

Fixed export bugs on contact and discussion pages #158

merged 2 commits into from
Aug 3, 2023

Conversation

Ritvik1121
Copy link
Collaborator

Changed the the package used to create cvs export files so that it wasn't dependent on Firebase. Contact and discussion page export buttons now properly generate cvs file.

bbmcmann
bbmcmann approved these changes Aug 3, 2023
View reviewed changes
Copy link
Collaborator

@bbmcmann bbmcmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

runs well for me, only bug is site crash when you export an empty discussion. (Might happen with contacts as well but in theory it could never be empty so prob not important). Otherwise its good

@sonarcloud
Copy link

sonarcloud bot commented Aug 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Ritvik1121 Ritvik1121 merged commit d85b9d5 into dev Aug 3, 2023
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bbmcmann bbmcmann bbmcmann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ritvik1121 @bbmcmann