-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/previous projects #71
Conversation
…mages not showing up as well as image in wrong position
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So this looks pretty good so far. Thank you! For components like the carousel I usually prefer to find a library that does it for me so that I don't have to worry about all the complicated logic of the component and making sure it sizes dynamically. Also do you think you could add the prize categories to the site? So that visitors see which projects won what.
You might want to check out this cool component I found on NPM: https://www.npmjs.com/package/react-multi-carousel
app/last-year/page.tsx
Outdated
<div className="flex flex-col items-center h-full mx-8"> | ||
{" "} | ||
{/* Added horizontal margins here */} | ||
<img |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would replace this with Next's Image component, just for consistency and image optimization.
components/prev-projects/Arrow.tsx
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could remove this file if you switch to pre-built component
… into feature/Previous_Projects
Is there a way to do it without the library that seems more complicated and also not sure how I would use that and still match the figma design. |
The way that image carousels like this one are implemented are usually done by having a parent div with a fixed width and the css property Another thing that is important the Figma designs are not the end all be all, they are a suggestion for the layout, but ultimately the developer has the final say on the layout and design. If you want you could move the buttons, change their sizes, change colors, etc. I strongly encourage you to change the designs as the design for the buttons on Figma was not supposed to be like that on the site. Lastly, about the prize categories, I would recommend placing them under the project title in maybe smaller font? Ultimately its up to you as the dev. |
…pi/HackRPI-Website-2024 into feature/Previous_Projects
…pi/HackRPI-Website-2024 into feature/Previous_Projects
Please briefly describe the changes made in your pull request below
Implemented the entire previous projects from 2023 page
Known Issues
If your changes made visual updates to the website, please add screenshot(s) below