Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set text/plain content-type on Micropub create response #25

Merged
merged 1 commit into from
Dec 20, 2023
Merged

Set text/plain content-type on Micropub create response #25

merged 1 commit into from
Dec 20, 2023

Conversation

jlelse
Copy link
Contributor

@jlelse jlelse commented Dec 20, 2023

This fixes compatibility with the Sparkles micropub client (https://sparkles.sploot.com/)

Copy link

codecov bot commented Dec 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8f2ce2a) 83.30% compared to head (3508624) 83.31%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #25      +/-   ##
==========================================
+ Coverage   83.30%   83.31%   +0.01%     
==========================================
  Files           9        9              
  Lines        1000     1001       +1     
==========================================
+ Hits          833      834       +1     
  Misses        117      117              
  Partials       50       50              
Files Coverage Δ
micropub/handler.go 87.37% <100.00%> (+0.06%) ⬆️

Copy link
Owner

@hacdias hacdias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will approve because I don't think it'll hurt. However, I think it's quite odd that that client is checking for the content-type on responses that are not expected to have any content themselves. Maybe it'd be good to open an issue with them too.

@hacdias hacdias merged commit bddf566 into hacdias:main Dec 20, 2023
3 checks passed
@jlelse
Copy link
Contributor Author

jlelse commented Dec 20, 2023

CC @benjifs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants