Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ORCID to registration form #19

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Add ORCID to registration form #19

wants to merge 10 commits into from

Conversation

cthoyt
Copy link
Member

@cthoyt cthoyt commented Mar 28, 2022

This PR demonstrates the following:

  1. Adding ORCID to the registration form (character (not varying) length 19 in the database)
  2. Rewriting the HTML/CSS for the registration form to use bootstrap (even further, this could use a modal)
  3. Adds text during registration about how curations will be licensed and distributed using ORCID, but not email.

How we tested this

We ran cogex locally while on VPN into the hms network and were able to register a new user then login. We might want to do a more detailed test with an actual deployment, but it seems like we're on track.

Affected Repositories

Screenshots

Screen Shot 2022-03-28 at 14 08 45

Screen Shot 2022-03-28 at 14 08 49

This commit refactors the form to use bootstrap components. It now looks much nicer.

Unfortunately this commit makes the diff quite large, but this was necessary to make the HTML anywhere near readable.
@kkaris
Copy link
Contributor

kkaris commented Jun 13, 2023

Should the orcid field be mandatory?

@cthoyt
Copy link
Member Author

cthoyt commented Jun 13, 2023

Yes

@bgyori
Copy link
Member

bgyori commented Jun 14, 2023

Why does it have to be mandatory though? Those who want to supply it can but if they don't want to that should be fine too.

@cthoyt
Copy link
Member Author

cthoyt commented Jun 14, 2023

If we ask people to provide this information on registration, it increases the value of the curations in that we can connect them to a structured identifier for the creator. I would like to be able to upload statistics of curations in INDRA to APICURON, and therefore ORCID would be necessary to do that.

I don't think it's such a big effort to make an ORCID and copy paste it, so I don't think anyone would complain here. In an ideal world, we'd use single sign on based on ORCID itself (maybe a good project for Tenzin).

That all being said, there's no technical reason that requires this, so if you don't think this is a good enough reason, we can make it optional on the registration.

@cthoyt
Copy link
Member Author

cthoyt commented Jun 14, 2023

@bgyori other update - klas and I just tested this, and it works for registration and showing ORCID for people who are logged in!

@cthoyt cthoyt marked this pull request as ready for review June 14, 2023 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants