-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ORCID to registration form #19
base: master
Are you sure you want to change the base?
Conversation
This commit refactors the form to use bootstrap components. It now looks much nicer. Unfortunately this commit makes the diff quite large, but this was necessary to make the HTML anywhere near readable.
Should the orcid field be mandatory? |
Yes |
Why does it have to be mandatory though? Those who want to supply it can but if they don't want to that should be fine too. |
If we ask people to provide this information on registration, it increases the value of the curations in that we can connect them to a structured identifier for the creator. I would like to be able to upload statistics of curations in INDRA to APICURON, and therefore ORCID would be necessary to do that. I don't think it's such a big effort to make an ORCID and copy paste it, so I don't think anyone would complain here. In an ideal world, we'd use single sign on based on ORCID itself (maybe a good project for Tenzin). That all being said, there's no technical reason that requires this, so if you don't think this is a good enough reason, we can make it optional on the registration. |
@bgyori other update - klas and I just tested this, and it works for registration and showing ORCID for people who are logged in! |
This PR demonstrates the following:
How we tested this
We ran cogex locally while on VPN into the hms network and were able to register a new user then login. We might want to do a more detailed test with an actual deployment, but it seems like we're on track.
Affected Repositories
emmaa
- see emmaa_service/api.py and emmaa_service/templates/emmaa_page_template.htmlindra_db
- see indra_db_service/call_handlers.py, indra_db_service/api.py, indra_db_service/templates/idbr_statements_view.html and indra_db_service/templates/idbr_template.htmlindra_cogex
- see indra_cogex/apps/wsgi.py and indra_cogex/apps/templates/base.htmlScreenshots