Replace Pegdown with Commonmark #366
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview at https://github.com/Vertispan/gwtproject.org |
|
The hosting for the link above is at https://www.gwtproject.org.vertispan.com/ - the contents from gwtproject/gwt-site-webapp#13 is also included in that build. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pegdown is no longer maintained, which will cause problems when upgrading build pipeline to Java 17.
Also it's nice to use an implemenntation of Markdown that is compatible with GH previews and IDE plugins -- commonmark seems to do quite well.
Three differences had to be handled in this PR though:
--to en-dash,---to em-dash, quotes) out of the box, HTML entities can be used instead.Fixes #332