Skip to content

Commit

Permalink
Let's see if we can now get by without passing the GITHUB_TOKEN env
Browse files Browse the repository at this point in the history
  • Loading branch information
bdestombe committed May 27, 2024
1 parent 64b03fc commit 4a6d933
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 6 deletions.
5 changes: 0 additions & 5 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -40,9 +40,6 @@ jobs:
flake8 . --count --exit-zero --max-complexity=10 --max-line-length=80 --statistics
- name: Download executables needed for tests
env:
GITHUB_TOKEN: ${{ github.token }} # Needed for downloading executables
NLMOD_SUPPRESS_EXE_VERION_CHECK: "True"
shell: bash -l {0}
run: |
python -c "import nlmod; nlmod.util.download_mfbinaries()"
Expand All @@ -51,8 +48,6 @@ jobs:
env:
NHI_GWO_USERNAME: ${{ secrets.NHI_GWO_USERNAME}}
NHI_GWO_PASSWORD: ${{ secrets.NHI_GWO_PASSWORD}}
GITHUB_TOKEN: ${{ github.token }} # Needed for downloading executables
NLMOD_SUPPRESS_EXE_VERION_CHECK: "True"
run: |
py.test ./tests -m "not notebooks"
Expand Down
3 changes: 2 additions & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ full = [
]
knmi = ["h5netcdf", "nlmod[grib]"]
grib = ["cfgrib", "ecmwflibs"]
test = ["pytest>=7", "pytest-cov", "pytest-dependency"]
test = ["pytest>=7", "pytest-cov", "pytest-dependency", "pytest-env"]
nbtest = ["nbformat", "nbconvert>6.4.5"]
lint = ["flake8", "isort", "black[jupyter]"]
ci = ["nlmod[full,lint,test,nbtest]", "netCDF4>=1.6.3", "pandas<2.1.0"]
Expand Down Expand Up @@ -107,5 +107,6 @@ line-length = 88
extend-include = ["*.ipynb"]

[tool.pytest.ini_options]
env = ["NLMOD_SUPPRESS_EXE_VERION_CHECK=True"]
addopts = "--strict-markers --durations=0 --cov-report xml:coverage.xml --cov nlmod -v"
markers = ["notebooks: run notebooks", "slow: slow tests", "skip: skip tests"]

0 comments on commit 4a6d933

Please sign in to comment.