Cand v1.90 #3
Open
Cand v1.90 #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tested with instantclient version 21.5 and also this version should be added to @bad_oci_vers.
major version number.
Removing outdated information from the list.
This changes the way things are done during login6 (connect). In particular: 1. OCIEnv is cached based on character sets and mode. One copy is used in all threads (so OCI_THREADED is important!) 2. There are no more global variables for character sets. So each connection uses exactly what is specified at connection time. Thus option ora_envhp is removed. 3. Improved support for DRCP. Now the pools are independent from threads. The pool is defined by DSN and UID. No more leaking of connections or pools. When last imp_drh goes away the pools are released. It is now also possible to tag sessions in addition to using connection_class (the latter works only with DRCP). 4. Reauthenticate now keeps old session as long as possible, so if new identity is wrong, then old session stays intact. 5. Support for using shared variables is also improved. There is now additional function ora_shared_release that cleans up shared connection, when it is not needed anymore. Though it is still cleaner to used DRCP. No more handles are leaking. 6. Support for imp_take is improved. No handles are leaking. But it is cleaner to use DRCP. 7. Small fixes for compilation and handling of attributes.
This version uses to defines from oci.h, which where added after version 12. Since I don't know exact version, when they were added, I protect their usage by check for OCI above 18. For older OCI these variables will be unavailable. Additionally I've tried to fix some warnings in Makefile.PL and stopped t/25plsql.t from checking if OCI has bug. After all DBD::Oracle does not protect against this bug, so there is no sense to check if OCI has it.
Added freeing of allocated handle. It is not needed anymore since OCIAttrSet copies its conent (according to Oracle developers)
The GHA will build against the "latest" Ubuntu/Perl/OracleXE/InstantClient that is currently available.
Some old systems can not use inline function
The latest stable release of DBD::Oracle listed the wrong bug tracker and repository because it was released from a fork, and the [GithubMeta] plugin used that fork to set the metadata. Remove that plugin, and instead specify the bug tracker and repository explicitly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After trying to compile it against OCI 12 I had to add few compile-time checks since 2 defines are added to oci.h after OCI 12.
Additionally I've fixed some of the warnings produced by Makefile.PL.
Note, there is still warning about mismatch between MANIFEST and actual files. I didn't fix that, since I'm not sure who has removed the files and why.
dbd-ora-patch.txt