Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nameko challenge - Wilson Pereira #2

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

wilsonfilho
Copy link

@wilsonfilho wilsonfilho commented Nov 3, 2023

  • Added to new endpoints: Delete products and List Order

  • Added Unit tests for new endpoints

  • Added Smoke and Performance tests

  • Added a refactoring related to POST method for /orders to improve the performance tests

  • Answer to question one:

    • Upon investigation, it was observed that during the process of creating a new order using the POST method for /orders, all products were being retrieved, which appeared to be an unnecessary step. This operation exhibited an unusual behavior, as the response time of the endpoint increased with the growth in the number of products. This behavior was unexpected since the creation of a new order should ideally remain independent of the total number of products.
  • Answer to question two:

    • Checking for invalid product IDs within the order details to reduce unnecessary retrieval.
    • Only retrieving product details for the products that are included in the order.

By making these changes, you can optimize the creation of new orders without impacting the response time due to unnecessary product data retrieval.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant